[Webkit-unassigned] [Bug 103971] FontPlatformData has unnecessary m_textOrientation member

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103971


mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #5 from mitz at webkit.org <mitz at webkit.org>  2012-12-04 09:56:07 PST ---
(In reply to comment #4)
> (From update of attachment 177417 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177417&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Nothing in SimpleFontData depends on the FontPlatformData’s textOrientation, so we don’t
> 
> Is the strange character here you doing something wrong, or bugs.webkit.org doing something wrong?

This is our friend bug 75394.

> 
> >> Source/WebCore/css/CSSFontFaceSource.cpp:115
> >> +                       | (fontDescription.orientation() == Vertical ? 4 : 0) | (syntheticBold ? 2 : 0) | (syntheticItalic ? 1 : 0);
> > 
> > Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> 
> For what it’s worth I prefer the 4-space indent that the style script calls for. But I don’t think adding formatting changes to this patch is a good idea.

I agree. Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.