[Webkit-unassigned] [Bug 102857] Fix a problem that GestureTap event is not converted to mouse event on the top frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102857





--- Comment #12 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-12-04 07:54:57 PST ---
(From update of attachment 175476)
View in context: https://bugs.webkit.org/attachment.cgi?id=175476&action=review

This patch isn't making EventHandler any more healthy.

> Source/WebCore/ChangeLog:17
> +        It is hard to wrote a test case as we need a new test plugin for this. But this change shouldn't affect the
> +        current layout tests

This seems bad -- don't we need some sort of coverage? How would I know if I broke this fix? Also, no period at the end of the sentence.

> Source/WebCore/page/EventHandler.cpp:151
> +#if ENABLE(GESTURE_EVENTS)

Every time you add an ifdef, there's a kitten that dies somewhere :-\

> Source/WebCore/page/EventHandler.h:465
> +    static Frame* gestureTapOriginatingFrame;

Static frame ptr! That seems nasty. Even though you just use it for comparison, it's a bad smell.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.