[Webkit-unassigned] [Bug 102686] [V8] toFastV8 for non-Nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102686


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177259|review?                     |review-
               Flag|                            |




--- Comment #9 from Adam Barth <abarth at webkit.org>  2012-12-03 11:57:15 PST ---
(From update of attachment 177259)
View in context: https://bugs.webkit.org/attachment.cgi?id=177259&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:585
> +        my $fastWrapper = $codeGenerator->IsSubType($interface, "Node") ? "impl->wrapper()" : "DOMDataStore::mainWorldStore()->get(impl)";

Very clever!

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1076
> +        if (IsDOMNodeType($interfaceName)) {

In principle, we should be able to use toV8Fast whenever $interfaceName is ScriptWrappable.  We can have the compiler do the dispatch by exposing DOMDataStore::wrapperIsStoredInObject publicly.  We can do that in a subsequent patch if you like.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.