[Webkit-unassigned] [Bug 103642] Add support for generic types in arrays and sequences to the code generators

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103642


Adam Bergkvist <adam.bergkvist at ericsson.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176978|0                           |1
        is obsolete|                            |
 Attachment #176978|review?                     |
               Flag|                            |
 Attachment #177263|                            |review?
               Flag|                            |




--- Comment #9 from Adam Bergkvist <adam.bergkvist at ericsson.com>  2012-12-03 09:01:31 PST ---
Created an attachment (id=177263)
 --> (https://bugs.webkit.org/attachment.cgi?id=177263&action=review)
Updated patch

(In reply to comment #8)
> (From update of attachment 176978 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176978&action=review
> 
> Thanks for updating the patch. Almost looks OK.
> 
> > Source/WebCore/bindings/js/JSDOMBinding.h:416
> > +    Vector<RefPtr<T> > toHostObjectArray(JSC::ExecState* exec, JSC::JSValue value, T* (*toT)(JSC::JSValue value))
> 
> toRefPtrNativeArray() might be a better name, as this is just another version of toNativeArray().

Fixed.

> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3070
> > +    return "Vector<" . GetNativeInnerVectorType($arrayOrSequenceType) . ">" if $arrayOrSequenceType;
> 
> Can't you use GetNativeType() ?

That was my initial approach as well (since I use it for V8), but the JSC-version of GetNativeType doesn't behave the same as the V8 counterpart for some types. For example, DOMString is translated to "const String&" instead of "String".

> > Source/WebCore/bindings/v8/V8Binding.h:211
> > +    Vector<RefPtr<T> > toHostObjectArray(v8::Handle<v8::Value> value)
> 
> toRefPtrNativeArray() might be a better name.

Fixed.

The build errors on EFL were due to a mismatch between the IDL type and the implementation type in the Vibration API. I've added a workaround and filed a separate bug to resolve that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.