[Webkit-unassigned] [Bug 95923] [EFL] Implement GCActivityCallback with platform timer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 07:38:59 PST 2012


--- Comment #16 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-03 07:41:21 PST ---
(From update of attachment 177172)
View in context: https://bugs.webkit.org/attachment.cgi?id=177172&action=review

> Source/JavaScriptCore/PlatformEfl.cmake:2
> +    runtime/GCActivityCallback.cpp

As Simon said, I also think this file is not cross-platform. At least, I think we shouldn't remove existing file for port implementation as here. Generally, each port has its own implementation file for similar case. For example, in this case, I think we should have GCActivityCallbackEfl.h/.cpp for now at least. I think you need to file a new bug for this issue regardless of which method is better(Simon's suggestion or support for each port implementation(CF, blackberry, EFL port and so on). Then, I think you can add this patch for EFL port.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list