[Webkit-unassigned] [Bug 103729] [GTK] Custom URI schemes stop working on Epiphany using WebKit2 after killing the web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103729


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177214|1                           |0
        is obsolete|                            |




--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-12-03 03:19:27 PST ---
(From update of attachment 177214)
View in context: https://bugs.webkit.org/attachment.cgi?id=177214&action=review

> Source/WebKit2/ChangeLog:33
> +        * WebProcess/soup/WebSoupRequestManager.h: Make registerURIScheme public

nit: End all sentences with a period.

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:43
> -    notImplemented();
> +    parameters.urlSchemesRegistered = m_soupRequestManagerProxy->registeredURISchemes();

I guess you need to include WebSoupRequestManagerProxy.h in this file too.

> Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.cpp:65
> +    ASSERT(!m_registeredURISchemes.find(scheme));

find() returns notFound when item is not found, so you should use either m_registeredURISchemes.find(scheme) != notFound, or use Vector::contains() that returns a bool.

> Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.h:57
> +    const Vector<String>& registeredURISchemes() const
> +    {
> +        return m_registeredURISchemes;
> +    }

This could be a single line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.