[Webkit-unassigned] [Bug 103729] [GTK] Custom URI schemes stop working on Epiphany using WebKit2 after killing the web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103729





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-12-03 00:18:43 PST ---
(In reply to comment #4)
> Forgot to comment on some of your suggestions:
> 
> >> Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.cpp:64
> >> +    m_registeredURISchemes.append(scheme);
> >
> > The API layer should make sure the same scheme is not registered twice, now that >we have a vector with the list of schemes, we could add an ASSERT to check the >scheme is not already in the Vector.
> 
> This means that we have to iterate (one way or another) through the vector which, although it might be insignificant, is extra processing.

ASSERT is no-op for a release build, so it's not a problem.

> > Instead of using an #ifdef move this code to WebContext::platformInitializeWebProcess() in Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp.
> 
> I didn't put it in there because I need the soupRequestManagerProxy that the WebContext.cpp already has.
> Also, if this works for both the Gtk and Efl implementations, isn't it better than touching two files?

WebContextGtk.cpp and WebContextEfl.cpp are the same class than WebContext, the files simply add implementation for methods specific to the platform, so you can use soupRequestManagerProxy from them. WebContext::platformInitializeWebProcess() was added exactly for that, so I prefer code in platform specific files and #ifdefs in cross platform code, when possible.

> > Instead of using #ifdef, move the code to WebProcess::platformInitializeWebProcess() in Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp. 
> 
> I didn't put it in there because I need the soupRequestManager that the WebProcess.cpp already has.

Same here, you can use soupRequestManager from WebProcessSoup.cpp, it's the same class.

> Let me know if I'm missing some smart way to access these members from the files you mentioned.

Nothing smart, simply use them :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.