[Webkit-unassigned] [Bug 103729] [GTK] Custom URI schemes stop working on Epiphany using WebKit2 after killing the web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103729





--- Comment #4 from Joaquim Rocha <jrocha at igalia.com>  2012-12-02 08:48:53 PST ---
Forgot to comment on some of your suggestions:

>> Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.cpp:64
>> +    m_registeredURISchemes.append(scheme);
>
> The API layer should make sure the same scheme is not registered twice, now that >we have a vector with the list of schemes, we could add an ASSERT to check the >scheme is not already in the Vector.

This means that we have to iterate (one way or another) through the vector which, although it might be insignificant, is extra processing.

> Instead of using an #ifdef move this code to WebContext::platformInitializeWebProcess() in Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp.

I didn't put it in there because I need the soupRequestManagerProxy that the WebContext.cpp already has.
Also, if this works for both the Gtk and Efl implementations, isn't it better than touching two files?

> Instead of using #ifdef, move the code to WebProcess::platformInitializeWebProcess() in Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp. 

I didn't put it in there because I need the soupRequestManager that the WebProcess.cpp already has.

Let me know if I'm missing some smart way to access these members from the files you mentioned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.