[Webkit-unassigned] [Bug 103772] Teach OwnPtr and RefPtr to understand Arena'd objects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 1 15:19:49 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103772





--- Comment #7 from Maciej Stachowiak <mjs at apple.com>  2012-12-01 15:22:09 PST ---
(In reply to comment #4)
> So I have a working patch...  But unfortunately it doesn't really make sense to ever have an OwnPtr<RenderObject> as RenderWidget (a RenderObject subclass) expects to be ref-counted. :(

RenderWidget is an odd duck. It would be nicer if all RenderObjects were refcounted in part so we could avoid the strangeness of Widget being refcounted while being part of a class hierarchy that generally uses single ownership.

However, OwnPtr<RenderWidget> would still do the right thing, because RenderWidget overloads destroy() to actually deref() - it kind of has to anyway to interoperate with even the manual render tree memory management. See RenderWidget::destroy in RenderWidget.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list