[Webkit-unassigned] [Bug 104773] [EFL] Split WebCore into separate libraries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104773





--- Comment #14 from Halton Huo <halton.huo at gmail.com>  2012-12-27 22:37:48 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > Created an attachment (id=180777)
 --> (https://bugs.webkit.org/attachment.cgi?id=180777&action=review) [details] [details]
> > Patch
> This patch is verified with/without -DSHARED_CORE=ON, debug and release build, So far so good. I think it is ready for review. Again, If all agree goes with solution in comment #8, i will offer a different patch.

(In reply to comment #13)
> (In reply to comment #8)
> 
> > So what should build do when debug build but no "-DSHARED_CORE=ON"?
> > Option 1: Stop build and say debug build need set -DSHARED_CORE=ON
> 
> I prefer option 1. But, I'm not sure if we should stop to build when disabling SHARED_CORE. Or, we may ask if you wanna build without SHARED_CORE.

What about Option 3 - Only separate libwebcore.a when SHARED_CORE build? Which is functionally working according my testing and ready for review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.