[Webkit-unassigned] [Bug 105778] REGRESSION(r138394): platform/mac/accessibility/file-upload-button-subrole.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105778





--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2012-12-27 12:06:46 PST ---
> Alexey, you say that part of the change should be reverted.  How do you determine this?

Such a change would require review, not a rubber-stamp. Accessibility behavior changes should be discussed on their own merits, not be kept in the tree after an accidental commit by default.

"file upload button" certainly sounds like a more appropriate plain English description for the button, if I were to guess about the rationale for existing behavior.

I think that update-webkit-localizable-strings just always makes English key and value match, which wasn't the case before. You can use svn blame to determine when they were made different. Perhaps someone fixed the text in Localizable.strings without realizing that don't treat the file as authoritative.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.