[Webkit-unassigned] [Bug 78883] [GStreamer] AudioSourceProvider support in the MediaPlayer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78883





--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2012-12-27 10:42:15 PST ---
(From update of attachment 180805)
View in context: https://bugs.webkit.org/attachment.cgi?id=180805&action=review

>>> Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:46
>>> +}
>> 
>> This is a situation where I think having a single line for each pair makes this more readable.
> 
> Yes but the style bot will complain. I'd like to move this function to GStreamerVersioning or Utilities btw as it's a copy/paste of the one in AudioFileReader.

Yeah, the new style bot rule is pretty annoying. You can follow the style rule by simply using a 4 space indent instead of aligning things. For instance:

return gst_caps_new_simple("audio/x-raw", 
    "rate", G_TYPE_INT, static_cast<int>(sampleRate), 
    "channels", G_TYPE_INT, channels,
    "format", G_TYPE_STRING, gst_audio_format_to_string(GST_AUDIO_FORMAT_F32),
    "layout", G_TYPE_STRING, "interleaved",
    NULL);

I admit it isn't the prettiest thing in the world, but it's easier to see what's going on, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.