[Webkit-unassigned] [Bug 105292] [GStreamer] GstMessage handler in AudioDestination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105292





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-12-27 10:22:59 PST ---
(From update of attachment 179941)
View in context: https://bugs.webkit.org/attachment.cgi?id=179941&action=review

>>> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:68
>>> +    g_signal_connect(bus.get(), "message", G_CALLBACK(messageCallback), this);
>> 
>> See below.
> 
> The bus returned by gst_pipeline_get_bus() needs to be unreffed after usage.

Ah, then you are actually leaking it because you aren't using adoptGRef.

>>> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:140
>>> +        g_warning("Warning: %d, %s. Debug output: %s", error->code,  error->message, debug.get());
>> 
>> Wouldn't it make sense to use gst_debug_log here?
> 
> Well I wanted to use g_warning here so the user sees the message in the console, this is rather minimal error reporting but less hidden than GST_DEBUG :)
> 
> I used the same approach in the AudioFileReader BTW, so any change needed in this patch would need to be done there as well.

I guess it's okay as long as there is a way to disable the output. The issue with libraries that print to stderr and stdout is that they cannot be used easily for command-line tools that produce output.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.