[Webkit-unassigned] [Bug 105720] [GTK] Fix build failure and some nits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105720





--- Comment #13 from Zan Dobersek <zandobersek at gmail.com>  2012-12-27 01:01:49 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> > 
> > > configure.ac:662
> > > +AC_ARG_ENABLE(video_track,
> > 
> > There's no need for this configuration option as it doesn't introduce any additional dependencies.
> > 
> > To prevent compilation failure, changes should be made to CodeGeneratorObject.pm. I've checked the build failures and created a patch for that, I'll upload it up for a review in another bug.
> O.K.. another easy option is to enable video_track feature with video at the same time.
> 

That should also be done, actually I believe this is what the Mac port currently does. I've posted a patch that addresses the CodeGeneratorObject.pm changes in bug #105743.

> > > configure.ac:686
> > > +AC_ARG_ENABLE(css_transforms_animations_transitions_unprefixed,
> > 
> > This configuration option is unnecessary as well, it was only added due to people adding new features being uninformed about the new configuration flag criteria on the GTK port (which is my fault, really).
> Then are you going to remove these unnecessary option on your side?  If that's the case, I think it's better to keep perfect for the meantime.

Ah, of course, there's already a patch waiting for a review in bug #105522.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.