[Webkit-unassigned] [Bug 105720] [GTK] Fix build failure and some nits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105720





--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2012-12-26 10:21:35 PST ---
(From update of attachment 180673)
View in context: https://bugs.webkit.org/attachment.cgi?id=180673&action=review

>>>>> Source/WebKit/gtk/webkit/webkitwebviewprivate.h:33
>>>>> +#include "ResourceResponse.h"
>>>> 
>>>> In what circumstances does build fail without this being added? What feature is enabled/disabled?
>>>> If it is of valid cause, please proceed with pushing to get this part of the patch landed.
>>> 
>>> I found adding ResourceResponse.h is required only with the option '--with-acceleration-backend=clutter'. and the main reason of missing header is due to not supporting css_filter with clutter AC. In other words, ResourceResponse.h is not reached when enabling AC clutter since css_filter is turned off.
>>> I think it'll be not bad that adding ResourceResponse.h explicitly here. Any idea?
>> 
>> Can you paste the header dependency chain?
> 
> Sure. here it is.
> ./Source/WebCore/loader/ResourceResponse.h,
> ./Source/WebCore/loader/cache/CachedResource.h:33,
> ./Source/WebCore/loader/cache/CachedResourceHandle.h:29,
> ./Source/WebCore/loader/cache/CachedSVGDocumentReference.h:30,
> ./Source/WebCore/platform/graphics/filters/FilterOperation.h:45,
> ./Source/WebCore/platform/graphics/filters/FilterOperations.h:31,
> ./Source/WebCore/platform/graphics/GraphicsLayer.h:34,   >> CSS_FILTERS define is here.
> ./Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:22,
> ./Source/WebKit/gtk/webkit/webkitwebviewprivate.h:26

Thanks, but whoops! I should have also asked what fails when it isn't included.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.