[Webkit-unassigned] [Bug 105720] [GTK] Fix build failure and some nits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105720





--- Comment #7 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2012-12-26 09:42:24 PST ---
(In reply to comment #5)
> (From update of attachment 180673 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180673&action=review
> 
> The GTK port is currently in the process of cleaning up the various configuration options located in configure.ac which are not really needed. In short form, if the feature (guarded by any feature define) does not introduce external dependencies, there shouldn't be a corresponding configuration flag available. An exception to this is the SVG feature, the reason for the configuration flag being that the SVG code takes notable time to compile so there should be a way of disabling it.
O.K I got it. thanks for the kind comment.

> > Source/WebKit/gtk/webkit/webkitwebviewprivate.h:33
> > +#include "ResourceResponse.h"
> 
> In what circumstances does build fail without this being added? What feature is enabled/disabled?
> If it is of valid cause, please proceed with pushing to get this part of the patch landed.
I found adding ResourceResponse.h is required only with the option '--with-acceleration-backend=clutter'. and the main reason of missing header is due to not supporting css_filter with clutter AC. In other words, ResourceResponse.h is not reached when enabling AC clutter since css_filter is turned off.
I think it'll be not bad that adding ResourceResponse.h explicitly here. Any idea?

> 
> > configure.ac:662
> > +AC_ARG_ENABLE(video_track,
> 
> There's no need for this configuration option as it doesn't introduce any additional dependencies.
> 
> To prevent compilation failure, changes should be made to CodeGeneratorObject.pm. I've checked the build failures and created a patch for that, I'll upload it up for a review in another bug.
O.K.. another easy option is to enable video_track feature with video at the same time.

> > configure.ac:686
> > +AC_ARG_ENABLE(css_transforms_animations_transitions_unprefixed,
> 
> This configuration option is unnecessary as well, it was only added due to people adding new features being uninformed about the new configuration flag criteria on the GTK port (which is my fault, really).
Then are you going to remove these unnecessary option on your side?  If that's the case, I think it's better to keep perfect for the meantime.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.