[Webkit-unassigned] [Bug 105734] New: [Meta] Maintain a full list of ENABLE defines and default values in C header(s)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105734

           Summary: [Meta] Maintain a full list of ENABLE defines and
                    default values in C header(s)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: laszlo.gombos at webkit.org


There is a common interest to track the list of feature flags for the WebKit. At the moment the most complete list of feature flags are maintained on the WebKit Wiki (see http://trac.webkit.org/wiki/FeatureFlags ).

I propose to maintain the list of feature flags in (a) header file(s) instead of a wiki page that is disconnected from the source code. This approach has the following benefits:
 - Requires one (or perhaps more than one in the future) less steps to introduce a new feature flag (see also http://trac.webkit.org/wiki/AddingFeatures ).

 - The list of features and the source code is revisioned together, the two are never out of sync.

 - We could use the existing contribution process and tools to make sure that the list is correctly maintained (e.g. check-webkit-style could check if a patch uses an ENABLE macro that is not listed in the feature list header file.).

 - In the future this header file could be used by the port specific build system (and perhaps build-webkit as well) to get the list of features and the default values for those features.

 - We should also consider layer these macros properly together with the frameworks/libraries - have one header file for WebCore and a separate one for JavaScriptCore and move them out from WTF (Platform.h).

 I opened this bug as a meta bug as I expect several steps/patches to make some of these ideas happen.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.