[Webkit-unassigned] [Bug 105473] Implement :future pseudo class for the WebVTT ::cue pseudo element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105473





--- Comment #9 from Eric Carlson <eric.carlson at apple.com>  2012-12-23 15:58:49 PST ---
(From update of attachment 180558)
View in context: https://bugs.webkit.org/attachment.cgi?id=180558&action=review

> LayoutTests/ChangeLog:12
> +        * media/track/captions-webvtt/styling.vtt:
> +        * media/track/track-css-matching-expected.txt:
> +        * media/track/track-css-matching.html:

This does not list all of the changed and modified files.

Why was track-cue-rendering-inner-timestamps.html deleted?

> LayoutTests/media/track/track-css-matching.html:43
> +                consoleWrite("");
> +                consoleWrite("");
> +                consoleWrite("\n\n2. Test that cues are being matched properly by the ':future' pseudo class.");

Nit: consoleWrite("\n\n") doesn't introduce white-space. Use consoleWrite("<br><br>") instead.

> Source/WebCore/ChangeLog:18
> +        (WebCore::CSSSelector::pseudoId):
> +        (WebCore::nameToPseudoTypeMap):
> +        (WebCore::CSSSelector::extractPseudoType):

Please add per-method comments describing what you added/changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.