[Webkit-unassigned] [Bug 105642] Dubious cast from TextTrackCueBox to HTMLDivElement.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105642


Victor Carbune <victor at rosedu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.carlson at apple.com




--- Comment #1 from Victor Carbune <victor at rosedu.org>  2012-12-21 11:19:18 PST ---
Thanks for pointing this out.

(In reply to comment #0)
> The fix would be to change to the proper base class in TextTrackCueBox.cpp.   Looking at https://bugs.webkit.org/show_bug.cgi?id=79751, this was initially the design but went off the rails at comment 34,
> when rather than resolving the underlying issue, this bug was introduced as part of a workaround.
I remember what was the issue that determined me to this.

Most of the .mm config files in WebView included HTMLElement, but not
HTMLDivElement and therefore I wasn't completely sure it's appropriate to
simply include HTMLDivElement because of WebVTT.

So would it be appropriate to actually do just do this directly?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.