[Webkit-unassigned] [Bug 105480] Implement element type selectors for the WebVTT ::cue pseudo class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 20 16:38:47 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=105480


Dima Gorbik <dgorbik at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #180441|                            |review?
               Flag|                            |




--- Comment #2 from Dima Gorbik <dgorbik at apple.com>  2012-12-20 16:41:01 PST ---
Created an attachment (id=180441)
 --> (https://bugs.webkit.org/attachment.cgi?id=180441&action=review)
Proposed fix 0.1

I suggest moving tag comparison to the overloaded "==" operator of a QualifiedName. That would simplify SelectorChecker::tagMatches quite a bit.
All general tag names like i, b, ruby and rt are being already handled. This patch adds the support for rare cases with "c" and "v" tags.
I will add layout tests after the previous patch is being reviewed (https://bugs.webkit.org/show_bug.cgi?id=105473) because they will be based on the existing layout tests from that patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list