[Webkit-unassigned] [Bug 105486] Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 20 03:00:37 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=105486





--- Comment #2 from Sami Kyöstilä <skyostil at chromium.org>  2012-12-20 03:02:52 PST ---
(From update of attachment 180254)
View in context: https://bugs.webkit.org/attachment.cgi?id=180254&action=review

> Source/WebCore/rendering/RenderView.cpp:1042
> +        RenderBox* r = *it;

Nit: use full word variables.

> Source/WebCore/rendering/RenderView.h:231
> +    void markFixedPositionDescendantsNeedsMovementLayout();

Bikeshed: markFixedPositionDescendantsNeedMovementLayout sounds less awkward to me.

> LayoutTests/fast/repaint/relayout-fixed-position-after-scale.html:32
> +        window.internals.settings.setFixedElementsLayoutRelativeToFrame(true)

Nit: missing semicolon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list