[Webkit-unassigned] [Bug 105267] [EFL] Add guard around ContextMenuItemTagInspectElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105267





--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-20 01:22:03 PST ---
(In reply to comment #6)
> (From update of attachment 179930 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179930&action=review
> 
> > Source/WebKit/efl/ewk/ewk_contextmenu.h:112
> > +#if defined ENABLE_INSPECTOR && ENABLE_INSPECTOR
> 
> Wouldn't the use of #if ENABLE(INSPECTOR) do the same thing as above? I think its better to use the ENABLE(INSPECTOR) macro for consistency.

ENABLE(XXX) is defined to WTF/wtf/Platform.h. So, application which uses ewk_contextmenu.h should include the Platform.h to use ENABLE(XXX) macro. But, we don't install Platform.h file. We can't use ENABLE() in public header. Beside, as we already talked, to use macro in public header will make unneeded overhead when using public header.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.