[Webkit-unassigned] [Bug 105267] [EFL] Add guard around ContextMenuItemTagInspectElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105267





--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-19 22:28:55 PST ---
(From update of attachment 179930)
View in context: https://bugs.webkit.org/attachment.cgi?id=179930&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.h:118
> +#if defined ENABLE_INSPECTOR && ENABLE_INSPECTOR

If app want to use this INSPECT_ELEMENT type, app should define ENABLE_INSPECTOR macro, isn't it ? It looks app should do unnecessary job. I would suggest not to use ENABLE_INSPECTOR macro in public header as chromium port. Chromium port only uses macro in internal implementation. Any other comments ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.