[Webkit-unassigned] [Bug 105451] Unable to place caret in RTL Override Characters by mouse click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105451


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #180204|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2012-12-19 14:14:33 PST ---
(From update of attachment 180204)
View in context: https://bugs.webkit.org/attachment.cgi?id=180204&action=review

> Source/WebCore/rendering/RenderText.cpp:513
> -    if (!box->nextLeafChildIgnoringLineBreak()) {
> +    if (!box->nextLeafChildIgnoringLineBreak(false)) {

Just call nextLeafChild() instead. r- due to unnecessary changes to nextLeafChildIgnoringLineBreak and prevLeafChildIgnoringLineBreak.
Did you make sure selection made by mouse drag on http://trac.webkit.org/browser/trunk/LayoutTests/editing/selection/select-line-break-with-opposite-directionality.html
makes sense for all cases? (in addition to ones that are already tested).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.