[Webkit-unassigned] [Bug 105409] New: Refactor RenderText::linesBoundingBox() code for returning correct logical rect values.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105409

           Summary: Refactor RenderText::linesBoundingBox() code for
                    returning correct logical rect values.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: arpitabahuguna at gmail.com


RenderText::linesBoundingBox() returns an IntRect as per the writing mode.

Thus, appropriate "logical" left, right, top and bottom calls are made to retrieve the corresponding values.
logicalLeft(), logicalRight(), logicalTop() and logicalBottom() (called on the inlineBox), all return values as per the writing mode.

Yet, while computing the width and height for the returned rect, we further interchange the values (for vertical writing mode), even though that has already been taken care of (by using the logical method calls).

This ultimately results in the returned rect not having the width and height set as per the writing mode. Or, in other words, the width and height set on the returned rect are always as per the horizontal writing mode.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.