[Webkit-unassigned] [Bug 105085] Pass debuggerTaskMode as a parameter in WorkerScriptDebugServer constructor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105085





--- Comment #5 from Seokju Kwon <seokju.kwon at gmail.com>  2012-12-18 18:00:32 PST ---
(In reply to comment #3)
> (From update of attachment 179582 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179582&action=review
> 
> > Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp:96
> > +        result = m_workerContext->thread()->runLoop().runInMode(m_workerContext, WorkerScriptDebugServer::debuggerTaskMode);
> 
> We should leave only one of WorkerDebuggerAgent::debuggerTaskMode and WorkerScriptDebugServer::debuggerTaskMode and remove other one. It'd prefer leaving  WorkerDebuggerAgent::debuggerTaskMode but WorkerScriptDebugServer should not depend on WorkerDebuggerAgent as dependency is in the opposite direction. To overcome this we way pass debuggerTaskMode as a parameter in WorkerScriptDebugServer constructor.

As you said, I have fixed them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.