[Webkit-unassigned] [Bug 105343] New: [Mac] Remove Platform.h macros from WebKit2 Private Headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105343

           Summary: [Mac] Remove Platform.h macros from WebKit2 Private
                    Headers
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org


WebKit's public headers are free of Platform.h/Compiler.h macros, but it has a few uses in its private headers. This should be cleaned up and "PrivateHeaders" added to the check for macros build phase.

    shell> TARGET_BUILD_DIR="$build/Release" PROJECT_NAME="WebKit2" SHALLOW_BUNDLE="NO" ./Tools/Scripts/check-for-inappropriate-macros-in-external-headers PrivateHeaders
    ERROR: 'WebKit2.framework/Versions/A/PrivateHeaders/WKBundleInspector.h:31' included forbidden macro 'ENABLE' => '#if ENABLE(INSPECTOR)'
    ERROR: 'WebKit2.framework/Versions/A/PrivateHeaders/WKBundleInspector.h:53' included forbidden macro 'ENABLE' => '#endif // ENABLE(INSPECTOR)'
    ERROR: 'WebKit2.framework/Versions/A/PrivateHeaders/WKBundlePage.h:437' included forbidden macro 'ENABLE' => '#if defined(ENABLE_INSPECTOR) && ENABLE_INSPECTOR'
    ERROR: 'WebKit2.framework/Versions/A/PrivateHeaders/WKRetainPtr.h:71' included forbidden macro 'COMPILER' => '#if COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES)'
    ERROR: 'WebKit2.framework/Versions/A/PrivateHeaders/WKRetainPtr.h:118' included forbidden macro 'COMPILER' => '#if COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES)'
    ERROR: 'WebKit2.framework/Versions/A/PrivateHeaders/WKRetainPtr.h:176' included forbidden macro 'COMPILER' => '#if COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES)'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.