[Webkit-unassigned] [Bug 105324] Use ElementTraversal in LiveNodeListBase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 18 12:21:55 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=105324





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2012-12-18 12:24:11 PST ---
(In reply to comment #4)
> (From update of attachment 179980 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179980&action=review
>
> > Source/WebCore/html/HTMLCollection.cpp:584
> > +        offsetInArray = m_cachedElementsArrayOffset;
> > +        while (currentOffset != offset && (currentElement = virtualItemAfter(offsetInArray, currentElement)))
> > +            ++currentOffset;
> 
> This doesn't seem right virtualItemAfter needs to update m_cachedElementsArrayOffset. You probably need to enable microdata in order to test this change.

Forget about this comment. I misread your code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list