[Webkit-unassigned] [Bug 101725] [V8] Inspector does not callback IDB methods in context

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101725





--- Comment #17 from Yury Semikhatsky <yurys at chromium.org>  2012-12-18 00:50:27 PST ---
(In reply to comment #16)
> (From update of attachment 173236 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173236&action=review
> 
> >> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:675
> >>      RefPtr<DatabaseLoader> databaseLoader = DatabaseLoader::create(document, requestCallback);
> > 
> > Why do we have to enter V8 context while calling a native function which by the way accepts ScriptExecutionContext and can enter the context if it need one? It seems completely wrong to me. Looks like we should make DatabaseLoader::create instead not to make assumptions about the v8 context stack, is there any problem with that approach?
> 
> if ScriptExecutionContext were enough to determine context, I would be using it.  Unfortunately, for isolated worlds, ScriptExecutionContext is simply not enough. It could be that the context needs to be stored somewhere earlier and reused at the points I changed, but since I know nothing about the way inspector works, I can't say what the correct solution here is at all.

Regardless of inspector code why DatabaseLoader::create depends on the JS context that calls it? Can we implement the check in the JS bindings where control flows from JS to native code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.