[Webkit-unassigned] [Bug 105045] Enable video caption controls on Windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105045





--- Comment #3 from Roger Fong <roger_fong at apple.com>  2012-12-14 14:12:30 PST ---
(In reply to comment #2)
> (From update of attachment 179510 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179510&action=review
> 
> > Source/WebCore/rendering/RenderThemeWin.h:28
> > +#include <SafariTheme/SafariThemeConstants.h>
> 
> Is this change needed?

Yeah it's to get supportsClosedCaptioning() in RenderThemeWin to return true.
It checks to see that SAFARI_THEME_VERSION >= 4 which is defined in the constants file.

RenderThemeSafari includes SafariThemeConstants but it looks like it was missed in RenderThemeWin.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.