[Webkit-unassigned] [Bug 104849] Web Inspector: Don't throw exceptions when we don't have a callstack

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104849





--- Comment #3 from johnjbarton <johnjbarton at chromium.org>  2012-12-14 08:53:56 PST ---
(In reply to comment #2)
> (From update of attachment 179132 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179132&action=review
> 
> > Source/WebCore/inspector/front-end/ScriptsPanel.js:307
> > +            if (details.callFrames.length) 
> 
> Out of curiosity: have you seen this happening? 

Yes, I found this by having break-on-exceptions set on devtools-on-devtools.

> We expect at least one call frame at all times. Could be related to live editing?

I'm pretty sure the case I hit was live edit.


> 
> > Source/WebCore/inspector/front-end/ScriptsPanel.js:310
> > +                this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused, reason unknown."));
> 
> I don't think we need this line since we will anyways see the problem due to no call frames.

But as you say above the no-call-frames case is unexpected. So this message is really intended for us, so we can be alert for the no-call-frame case and learn about it.

However, I cannot find the output from setStatus() in the UI anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.