[Webkit-unassigned] [Bug 104910] [GTK] When in private mode WebKitGTK+ should not save HTTP authentication credentials to the persistent storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104910





--- Comment #5 from Alberto Garcia <agarcia at igalia.com>  2012-12-14 04:26:42 PST ---
(In reply to comment #4)
> > +        CredentialPersistence persistence;
> > +
> > +        if (rememberPassword && dialog->m_browsingMode == NormalMode)
> > +            persistence = CredentialPersistencePermanent;
> > +        else
> > +            persistence = CredentialPersistenceForSession;
>
> This could be one line.

I know, I did it on purpose because the alternative is a 150+ column
line, and I think it's much more readable like this.

But I can change it if you think it's better.

> I think that it would make more sense for the authentication dialog
> > to have no knowledge of the concept of browsing mode. Instead the
> > naming of these could be something like:
>
> enum PersistentStorageAllowed {
>     AllowPersistentStorage,
>     DisallowPersistentStorage,
> }

That sounds good to me.

> WebKit comments that are complete sentences should end with a period

I can also fix that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.