[Webkit-unassigned] [Bug 101904] [EFL][WK2] Add API to execute js script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101904





--- Comment #6 from Christophe Dumez <christophe.dumez at intel.com>  2012-12-14 00:34:45 PST ---
(From update of attachment 173587)
View in context: https://bugs.webkit.org/attachment.cgi?id=173587&action=review

>>>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:926
>>>> +struct _Ewk_View_Script_Execute_Callback_Context {
>>> 
>>> I think ewk_view_private.h or EwkViewImpl.h is more better place for this struct.
>> 
>> Why? if this struct is used only in ewk_view.cpp, then I think this is the right place for it. However, we don't use _ prefix for such structures anymore.
> 
> If so, what do you think ewk_view_private.h role ? Do you think it isn't for internal data type or struct ?

ewk_view_private.h should be used for structures / macros that need to be shared between several files.
In this case, Ewk_View_Script_Execute_Callback_Context is only used internally by ewk_view.cpp. There is no point in sharing it with other implementation files since none of them will use it. It would only make compile time longer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.