[Webkit-unassigned] [Bug 101904] [EFL][WK2] Add API to execute js script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101904





--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-13 22:10:45 PST ---
(From update of attachment 173587)
View in context: https://bugs.webkit.org/attachment.cgi?id=173587&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:926
> +struct _Ewk_View_Script_Execute_Callback_Context {

I think ewk_view_private.h or EwkViewImpl.h is more better place for this struct.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:939
> +    if (!ewkView || error)

What is error role here ? It looks QT and GTK ports don't take care of error.

Beside don't you need to delete callbackContext here ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:943
> +    JSGlobalContextRef jsGlobalContext = impl->ewkContext()->jsGlobalContext();

Don't you need to free jsGlobalContext using JSGlobalContextRelease() after finishing to use it ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:945
> +    if (!callbackContext->scriptExecuteCallback)

I think this line should be placed before above two lines.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:975
> +

Unneeded line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.