[Webkit-unassigned] [Bug 104279] [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104279


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178047|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2012-12-13 09:04:39 PST ---
(From update of attachment 178047)
View in context: https://bugs.webkit.org/attachment.cgi?id=178047&action=review

r=me, but please address Dan's comment and making sure to use the same ruby binary in test-webkitruby when running tests.

Also, I think Tools/Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/passing-expected.txt was probably renamed to pass-expected.txt, so it should be removed from the commit.

> Tools/Scripts/test-webkit-scripts:31
> +"""Run unit tests of WebKit's Perl, Ruby, and Python scripts."""

Nit:  Should it be "Perl, Python and Ruby scripts" to keep them alphabetized?  :)

> Tools/Scripts/test-webkit-scripts:80
> +        print('Note: Perl, Ruby, and Python results appear separately above.')

Ditto.

> Tools/Scripts/test-webkitruby:30
> +  puts %x{ ruby '#{test}' }

Does using "ruby" here imply that you're using the same ruby executable that was used to launch this script?  If not, we should use the path the ruby binary that was used to run this script (however you grab that in ruby; maybe "$0"?) to make the behavior more predictable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.