[Webkit-unassigned] [Bug 104631] Emphasis mark is printed after inline-block with justify

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104631


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178957|review?                     |review+
               Flag|                            |




--- Comment #5 from Dean Jackson <dino at apple.com>  2012-12-12 17:38:57 PST ---
(From update of attachment 178957)
View in context: https://bugs.webkit.org/attachment.cgi?id=178957&action=review

Some grammar changes. This is my first review of text layout, so I'm quite nervous and I hope I don't break anything :(

> Source/WebCore/ChangeLog:8
> +        Fix emphasis mark is printed after inline-block with justify.

-> "Do not print an emphasis mark after an inline-block when justified."

> Source/WebCore/ChangeLog:14
> +        If an inline-block is expanded, a space is added after inline-block.
> +        Emphasis mark is drawn over the space for the expand.
> +
> +        When an emphasis mark is drawn, check the charactor is the space.
> +        If so, don't draw emphasis mark.

-> "If an inline-block is expanded, it has a space appended to it. This space should not have any emphasis marks drawn."

> Source/WebCore/platform/graphics/WidthIterator.cpp:228
> +                                    glyphBuffer->add(0, fontData, m_expansionPerOpportunity);

I wonder if we should have a special name for a null glyph, or a glyph we don't care about?

> LayoutTests/ChangeLog:8
> +        Test that draw emphasis mark to justified inline box and text.

-> Test that emphasis marks are not drawn incorrectly in justified text with inline boxes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.