[Webkit-unassigned] [Bug 104768] Uninitialized text decoration color is propagated to ruby text.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104768





--- Comment #4 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2012-12-12 02:41:14 PST ---
(In reply to comment #3)
> (From update of attachment 178975 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178975&action=review
> 
> > Source/WebCore/rendering/InlineTextBox.cpp:978
> > +    underline = overline = linethrough = Color::transparent;
> 
> The fix doesn't seem right. getTextDecorationColors should be assigning correct values. If not, we need to fix the bug in getTextDecorationColors instead.

getTextDecorationColors() is used twice.
First is propagating normal text decoration color
Second is overwriting it  by first line color.

Setting transparent at the beginning of getTextDecorationColors() or RubyText "if" statement don't work well because 2nd getTextDecorationColors() don't know what is set by 1st getTextDecorationColors().

I think first line overwrite should be done at getTextDecorationColors().

However, getTextDecorationColors() have another bug, which is bug 104786, and the fix will depend on that.

Therefore, I fix this after fix bug 104786.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.