[Webkit-unassigned] [Bug 104329] [EFL] Refactor duplicate code into FileSystemEfl.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104329





--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-10 18:04:15 PST ---
(From update of attachment 178544)
View in context: https://bugs.webkit.org/attachment.cgi?id=178544&action=review

Almost looks good to me.

> Source/WebCore/platform/FileSystem.h:233
> +String getInspectorResourcePath();

I think *inspectorResourcePath* is better according to webkit coding style guideline

Precede setters with the word "set". Use bare words for getters. Setter and getter names should match the names of the variables being set/gotten.
Right:
void setCount(size_t); // sets m_count
size_t count(); // returns m_count

Wrong:
void setCount(size_t); // sets m_theCount
size_t getCount();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.