[Webkit-unassigned] [Bug 104472] [Windows]ASSERTION failed in Windows: css3/css3-modsel-33.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104472





--- Comment #4 from Tim Horton <timothy_horton at apple.com>  2012-12-10 11:22:16 PST ---
(From update of attachment 178402)
View in context: https://bugs.webkit.org/attachment.cgi?id=178402&action=review

>> Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:429
>> +    frameLoadDelegatePrivate = 0;
> 
> This seems like a good change, but would it be clearer if we used separate COMPtrs for the two possible cases? Maybe we should have each one declared within the scope of the DidFirstlayout and DidFirstVisuallyNonEmpty Layout?

I agree, Brent's plan (two separate locals inside the if blocks) is clearer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.