[Webkit-unassigned] [Bug 104523] build-webkit --chromium --ninja should show a better error message when ninja is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104523





--- Comment #2 from Nico Weber <thakis at chromium.org>  2012-12-10 08:38:36 PST ---
Now that I look at the code, my analysis was probably wrong. Here's the ninja discovery code from Tools/Scripts/webkitdirs.pm:

    # Find ninja.
    my $ninjaPath;
    if (commandExists('ninja')) {
        $ninjaPath = 'ninja';
    } elsif (-e 'Source/WebKit/chromium/depot_tools/ninja') {
        $ninjaPath = 'Source/WebKit/chromium/depot_tools/ninja';
    } else {
        die "ninja not found. Install chromium's depot_tools by running update-webkit first\n";
    }

ninja is a bash script in depot_tools, and that should always be found. Robert, does Source/WebKit/chromium/depot_tools exist on your box? (If not, do you know how `update-webkit --chromium` manages to find gclient?)


Here's the ninja bash script in depot_tools:

#!/bin/bash

# Copyright (c) 2012 Google Inc. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

OS="$(uname -s)"
THIS_DIR="$(dirname "${0}")"

if [ "${OS}" = "Linux" ]; then
  exec "${THIS_DIR}/ninja-linux64" "$@"
elif [ "${OS}" = "Darwin" ]; then
  exec "${THIS_DIR}/ninja-mac" "$@"
elif [[ ${OS} == CYGWIN* ]]; then
  exec cmd.exe /c `cygpath -t windows $0`.exe "$@"
elif [[ ${OS} == MINGW32* ]]; then
  cmd.exe //c $0.exe "$@"
else
  echo "Unsupported OS ${OS}"
  exit 1
fi


exec will probably print something like "don't know how to exec ninja-linux64" on a 32bit linux, and that diagnostic should certainly be better -- but it looks like this script isn't even called, so we need to figure out why that's not happening first.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.