[Webkit-unassigned] [Bug 104483] Wrong Enabled states on a ListBox

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 9 23:33:32 PST 2012


--- Comment #3 from chris fleizach <cfleizach at apple.com>  2012-12-09 23:35:57 PST ---
(From update of attachment 178417)
View in context: https://bugs.webkit.org/attachment.cgi?id=178417&action=review

It bugs me a bit that we're checking for aria_disabledAttr in two methods, but I see a bunch of different implementations that would make a common implementation a bit tricky and less glamorous to get right. 
I think if we continue to provide custom isEnabled implementations we should think about refactoring a bit, but I think this is OK in current form

just a minor comment about the layout tests

> LayoutTests/accessibility/listbox-enabled-states.html:35
> +        shouldBeTrue('accessibilityController.focusedElement.childAtIndex(4).isEnabled');

you should also include the js-post test scripts so that we get the successfullyParsed messages

> Source/WebCore/ChangeLog:3
> +        Wrong Enabled states on a ListBox

We should probably prefix the bug title with AX: * 
so that others know what this refers to

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list