[Webkit-unassigned] [Bug 98705] [EFL][WK2] Add Remote Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98705





--- Comment #22 from Christophe Dumez <christophe.dumez at intel.com>  2012-12-08 07:02:10 PST ---
(From update of attachment 178350)
View in context: https://bugs.webkit.org/attachment.cgi?id=178350&action=review

> Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:73
> +    String ext = localPath.substring(extStart != notFound ? extStart + 1 : 0);

As I commented before: substring(0) will return the whole string, which is not what you want if there is no file extension.

> Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:74
> +    contentType = WebCore::MIMETypeRegistry::getMIMETypeForExtension(ext);

Also commented before, we should probably check if ext is empty before calling getMIMETypeForExtension() since our implementation of getMIMETypeForExtension() does not.

> Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:82
> +    builder.appendLiteral("[");

append('[') is better

> Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:101
> +    builder.appendLiteral("]");

Ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.