[Webkit-unassigned] [Bug 104191] Implement matching cue by the class name with ::cue pseudo element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104191





--- Comment #11 from Dima Gorbik <dgorbik at apple.com>  2012-12-07 19:13:52 PST ---
(In reply to comment #7)
> (From update of attachment 177912 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177912&action=review
> 
> > Source/WebCore/css/CSSParser.cpp:10104
> > +#if ENABLE(VIDEO_TRACK)
> > +        // Don't set the tag for the PseudoCue element because the matching will not work when the tags are being compared.
> > +        if (!(specifiers->pseudoType() == CSSSelector::PseudoCue))
> > +#endif
> > +            specifiers->setTag(tag);
> 
> I don't quite understand this. The comment is not very helpful.

If we allow the tag to be set here, it will be matched against webvtt objects' tags, and the selector will be declined since tags are different. I am not sure how QualifiedName is computed and if it may be still used for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.