[Webkit-unassigned] [Bug 103067] Keyboard caret movement in textarea with RTL Override Character can make tab unresponsive

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 14:11:56 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103067


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177825|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org>  2012-12-07 14:14:23 PST ---
(From update of attachment 177825)
View in context: https://bugs.webkit.org/attachment.cgi?id=177825&action=review

> Source/WebCore/editing/VisiblePosition.cpp:148
> -                InlineBox* prevBox = box->prevLeafChild();
> +                InlineBox* prevBox = box->prevLeafChildIgnoringLineBreak();

Looks much better!

> LayoutTests/editing/selection/move-by-character-crash-test-textarea.html:11
> +    var test = document.getElementById("test_move_by_character");

Please use camelCase.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list