[Webkit-unassigned] [Bug 104354] IndexedDB: Don't use strings to represent serialized values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 09:42:42 PST 2012


--- Comment #4 from Alec Flett <alecflett at chromium.org>  2012-12-07 09:45:09 PST ---
(From update of attachment 178184)
Overall this is great - I was just saying to jsbell that this is an important one. (Note to self: we have to fix the V8 implementation to stop using String internally as well)

View in context: https://bugs.webkit.org/attachment.cgi?id=178184&action=review

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.h:74
> +Vector<char> encodeIDBValue(const Vector<uint8_t>&);

I'm not sure I see why we need encodeIDBValue/decodeIDBValue now - seems like they're just introducing additional string copies to do conversion from char <-> uint8_t - is there a way to cleverly use static_cast and the like to make the conversion safe?

Alternatively, can we just fix the LevelDB code to use uint8_t?

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:1844
>  String SerializedScriptValue::toWireString() const

add FIXME's to say "remove when..." for whatever is stopping this method (preferably in the form of a webkit bug) from being completely removed.. is it bindings code? Chromium code?

(and add the identical FIXME for all the methods that should be removed - I see a bunch)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list