[Webkit-unassigned] [Bug 104191] Implement matching cue by the class name with ::cue pseudo element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104191





--- Comment #9 from Hajime Morrita <morrita at google.com>  2012-12-06 22:06:45 PST ---
(From update of attachment 177912)
View in context: https://bugs.webkit.org/attachment.cgi?id=177912&action=review

>> Source/WebCore/css/CSSParser.cpp:10132
>> +    if (newSpecifier->isUnknownPseudoElement() || newSpecifier->pseudoType() == CSSSelector::PseudoCue) {
> 
> The current ToT calls this isCustomPseudoElement(). It is not clear to me what the exact meaning of that is supposed to be but maybe PseudoCue just needs to have that set?

isUnknownPseudo() is used to represent -webkit-* pseudo ids. 
Since web components (cough) allows page author to specify their own pseudo, we needed to refine this "unknown" category into:

- A. -webkit-* -> PseudoWebKitCustomElement
- B. x-* (for web components) -> PseudoUserAgentCustomElement
- C. really unknown -> PseudoUnknown

isCustomPseudoElement() matches A and B and isUnknownPseudo() now matches only C.
Does this make sense?

It looks PseudoCue is usual pseudo id and good to have its own enum entry.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.