[Webkit-unassigned] [Bug 103955] Make caret repainting container-aware

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 18:31:34 PST 2012


--- Comment #7 from Tien-Ren Chen <trchen at chromium.org>  2012-12-06 18:34:00 PST ---
I think the patch is almost ready for production. The layout test failures are expected and should be safe to rebaseline. PTAL.

Changes from last patch:
1. Corrected the layout test fail with RTL text. We no longer need to manually call flipForWritingMode(). repaintRectangle() will do the right thing for us.

2. Corrected the caret ghosting bug. We need to retain the previous Node* that rendered the caret for the last frame because we no longer store an absolute rect.

3. Added a layout test for transformation. There is actually an improvement over repaintRectangleInViewAndCompositedLayers() such that we now handle transformation correctly.

Layout test difference:
The 1-pixel inflation is removed from the repaint rect. I examined the layout test result and didn't observe any problems with that. The inflation is probably no longer needed with the container-aware approach.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list