[Webkit-unassigned] [Bug 103342] [EFL][WK2] Add ewk_settings APIs for text autosizing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 18:00:04 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103342


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176138|review?                     |review+
               Flag|                            |




--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-12-06 18:02:29 PST ---
(From update of attachment 176138)
View in context: https://bugs.webkit.org/attachment.cgi?id=176138&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:354
>> +    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
> 
> I think we don't need to keep this line when disabling TEXT_AUTOSIZING

The line is correct and people could give a null pointer.

I say leave it

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list