[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704


Noam Rosenthal <noam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177930|review?                     |review-
               Flag|                            |




--- Comment #46 from Noam Rosenthal <noam at webkit.org>  2012-12-05 22:08:33 PST ---
(From update of attachment 177930)
View in context: https://bugs.webkit.org/attachment.cgi?id=177930&action=review

I still don't get the point of accelerated canvas in coordinated graphics without graphics surfaces, and it's still not explained.

> Source/WebCore/ChangeLog:11
> +        for both cases using GRAPHICS_SURFACE and no GRAPHICS_SURFACE because it is not enabled by default in EFL currently.

This is a strange reasoning to implement a non-GraphicsSurface fallback.
There is already a fallback - non-accelerated 2d canvas. Why have another fallback that uses some sort of cairo surface and then paints to software?

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:351
> +    m_canvasPlatformLayer = platformLayer;
> +    m_canvasNeedsDisplay = true;
> +    if (client())
> +        client()->notifyFlushRequired(this);

This lines exist inside the #if clause, why not take them outside the clause altogether rather than have an #else?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.