[Webkit-unassigned] [Bug 104043] Implement general ::cue pseudo element for the <video>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104043





--- Comment #10 from Victor Carbune <victor at rosedu.org>  2012-12-05 17:33:18 PST ---
(From update of attachment 177639)
View in context: https://bugs.webkit.org/attachment.cgi?id=177639&action=review

> LayoutTests/ChangeLog:3
> +        Implement general ::cue pseudo element for the <video>

Would you have thoughts / knowledge about parsing / filter so that only some CSS properties can be applied?

> LayoutTests/media/track/track-css-all-cues-expected.txt:4
> +EXPECTED (getComputedStyle(textTrackDisplayElement(video).firstChild).color == 'rgb(255, 0, 0)') OK

Just nice to have would be tests for each allowed CSS properties mentioned in the spec.

> Source/WebCore/html/shadow/MediaControlElements.cpp:1307
> +    m_cueContainer = HTMLElement::create(spanTag, document);

Couldn't the same be achieved by overriding shadowPseudoId() in TextTrackCueBox?

It would avoid creating a container within a container and it would match
individually each list of WebVTT node objects.

> Source/WebCore/html/shadow/MediaControlElements.cpp:1308
> +    m_cueContainer->setShadowPseudoId(cue);

As Silvia mentioned you probably need to sync, as I think this should be setPseudo.
(looks to me that setShadowPseudoId was removed in http://trac.webkit.org/changeset/133749)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.